yuhuiyang commented on HBASE-22631:

[~wchevreuil]  RegionNode.offline()  will set the region state to State.OFFLINE 
and the next step AssignmentManager().undoRegionAsOpening will check the region 
state if it's Region OPENING . If region state is NOT OPENING do nothing .  
Obviously  the region state is not OPENING after the state.offline() had set 
the region to be OFFLINE, so  AssignmentManager().undoRegionAsOpening will do 
noting .   

> assign failed may make gced parent region appear again !!!
> ----------------------------------------------------------
>                 Key: HBASE-22631
>                 URL: https://issues.apache.org/jira/browse/HBASE-22631
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2
>    Affects Versions: 2.1.1
>            Reporter: yuhuiyang
>            Priority: Major
>         Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, 
> assignProcedure.txt, serverCrash.png, splitAndGc.png
> When i assign a region A the process is as follows:
> step1 : A is assigned to rs1 , and rs1 fails to open it .
> step2 : assignProcedure handleFailure .
> step3 : A is assign to rs2 and rs success to open it .
> Above is the normal flow . However when rs1 is restart after the reigon A was 
> split and GCRegionProcedure was successed , the region A appare again !
> The region is that reigon A is not removed from the serverMap correctly when 
> assignprocedure handleFailure . Because the code regionNode.offline() make 
> the regionNode's regionLocation to be null and make regionNode's state to 
> OFFLINE . So when the code 
> env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So 
> when the rs1 restart event triggers a serverCrashProcedure, it will get 
> reigons from serverMap and it will get the region A then A will be assigned 
> and hdfs dir will be created. 

This message was sent by Atlassian JIRA

Reply via email to