[
https://issues.apache.org/jira/browse/HBASE-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244324#comment-13244324
]
[email protected] commented on HBASE-5625:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4607/#review6622
-----------------------------------------------------------
I ran TestTableMapReduce and TestMultithreadedTableMapper with patch v5.
They passed.
Some minor comments below.
src/main/java/org/apache/hadoop/hbase/KeyValue.java
<https://reviews.apache.org/r/4607/#comment14303>
Please include vlength in the exception message
src/main/java/org/apache/hadoop/hbase/KeyValue.java
<https://reviews.apache.org/r/4607/#comment14304>
Should read 'BufferOverflowException if there'
src/main/java/org/apache/hadoop/hbase/KeyValue.java
<https://reviews.apache.org/r/4607/#comment14305>
Add a space between comma and fl.
src/main/java/org/apache/hadoop/hbase/client/Result.java
<https://reviews.apache.org/r/4607/#comment14306>
Is this comment needed ?
src/main/java/org/apache/hadoop/hbase/client/Result.java
<https://reviews.apache.org/r/4607/#comment14307>
This line can be removed.
src/test/java/org/apache/hadoop/hbase/client/TestResult.java
<https://reviews.apache.org/r/4607/#comment14308>
white space.
src/test/java/org/apache/hadoop/hbase/client/TestResult.java
<https://reviews.apache.org/r/4607/#comment14309>
Since benchmarking is hard to do, this test case can be dropped.
- Ted
On 2012-04-02 14:22:48, Tudor Scurtu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4607/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-02 14:22:48)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. When calling Result.getValue(), an extra dummy KeyValue and its associated
underlying byte array are allocated, as well as a persistent buffer that will
contain the returned value.
bq.
bq. These can be avoided by reusing a static array for the dummy object and by
passing a ByteBuffer object as a value destination buffer to the read method.
bq.
bq.
bq. This addresses bug HBASE-5625.
bq. https://issues.apache.org/jira/browse/HBASE-5625
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/KeyValue.java 243d76f
bq. src/main/java/org/apache/hadoop/hbase/client/Result.java df0b3ef
bq. src/test/java/org/apache/hadoop/hbase/client/TestResult.java f9e29c2
bq.
bq. Diff: https://reviews.apache.org/r/4607/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added value check to TestResult#testBasic and TestResult.testMultiVersion.
bq.
bq.
bq. Thanks,
bq.
bq. Tudor
bq.
bq.
> Avoid byte buffer allocations when reading a value from a Result object
> -----------------------------------------------------------------------
>
> Key: HBASE-5625
> URL: https://issues.apache.org/jira/browse/HBASE-5625
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.92.1
> Reporter: Tudor Scurtu
> Assignee: Tudor Scurtu
> Labels: patch
> Attachments: 5625.txt, 5625v2.txt, 5625v3.txt, 5625v4.txt, 5625v5.txt
>
>
> When calling Result.getValue(), an extra dummy KeyValue and its associated
> underlying byte array are allocated, as well as a persistent buffer that will
> contain the returned value.
> These can be avoided by reusing a static array for the dummy object and by
> passing a ByteBuffer object as a value destination buffer to the read method.
> The current functionality is maintained, and we have added a separate method
> call stack that employs the described changes. I will provide more details
> with the patch.
> Running tests with a profiler, the reduction of read time seems to be of up
> to 40%.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
