busbey commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 URL: https://github.com/apache/hbase/pull/251#issuecomment-522055881 > @busbey is this "handling of jdk7/jdk8 bit" something that I can take off your plate? Looks like it's something to do with the Yetus hbase-personality used in the pre-commit job. that'd be fabulous. the `hbase-personality.sh` that's in `dev-support` needs to have the function `personality_modules` updated to make sure we're ignoring the new module when jdk7 is active. We already have the maven profiles set up to activate depending on the jdk so that the module is only in the reactor when the correct jdk is available at runtime. Unfortunately, the maven plugin for yetus relies on the presence of a pom.xml file to identify modules rather than presence in the reactor. I'm not sure if it'll be faster to figure out what jdk is around or to figure out if maven thinks the module is in the reactor.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
