openinx commented on a change in pull request #504: HBASE-22871 Move the
DirScanPool out and do not use static field
URL: https://github.com/apache/hbase/pull/504#discussion_r314948628
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##########
@@ -485,10 +384,13 @@ public boolean setEnabled(final boolean enabled) {
}
/**
- * Attemps to clean up a directory, its subdirectories, and files.
- * Return value is true if everything was deleted. false on partial / total
failures.
+ * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
+ * everything was deleted. false on partial / total failures.
*/
- private class CleanerTask extends RecursiveTask<Boolean> {
+ private final class CleanerTask extends RecursiveTask<Boolean> {
+
+ private static final long serialVersionUID = -5444212174088754172L;
Review comment:
nit: do we really need this serialVersiolUID ? I don't see any
serialization...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
