[ 
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244468#comment-13244468
 ] 

Lars Hofhansl commented on HBASE-5682:
--------------------------------------

Yeah, my comment was wrong. It's not generally doing that.

What I do find is if the ZK quorum is down, none of getZookeeperWatcher(), 
masterAddressTracker.start(), and rootRegionTracker.start() actually fail. They 
just retry and then happily return, which is as designed, because they are 
asynchronous.
Would be nice to have a isAlive or waitForConnect method on ZKW that would 
throw if the connection could not be established.

The attached patch is still a vast improvement, but it could be made better 
(even with zk timeout set to 100ms and retries to 3, it still take 22s for 
ensureZookeeperTrackers to finish).

                
> Allow HConnectionImplementation to recover from ZK connection loss (for 0.94 
> only)
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-5682
>                 URL: https://issues.apache.org/jira/browse/HBASE-5682
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Critical
>             Fix For: 0.94.0
>
>         Attachments: 5682-all-v2.txt, 5682-all-v3.txt, 5682-all.txt, 
> 5682-v2.txt, 5682.txt
>
>
> Just realized that without this HBASE-4805 is broken.
> I.e. there's no point keeping a persistent HConnection around if it can be 
> rendered permanently unusable if the ZK connection is lost temporarily.
> Note that this is fixed in 0.96 with HBASE-5399 (but that seems to big to 
> backport)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to