Apache9 commented on a change in pull request #501: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#discussion_r314985585
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##########
@@ -59,18 +58,22 @@ public static boolean isMetaClearingException(Throwable
cur) {
if (cur == null) {
return true;
}
- return !isSpecialException(cur) || (cur instanceof RegionMovedException)
- || cur instanceof NotServingRegionException;
+ return !regionDefinitelyOnTheRegionServerException(cur);
}
- public static boolean isSpecialException(Throwable cur) {
- return (cur instanceof RegionMovedException || cur instanceof
RegionOpeningException
- || cur instanceof RegionTooBusyException || cur instanceof
RpcThrottlingException
- || cur instanceof MultiActionResultTooLarge || cur instanceof
RetryImmediatelyException
- || cur instanceof CallQueueTooBigException || cur instanceof
CallDroppedException
- || cur instanceof NotServingRegionException || cur instanceof
RequestTooBigException);
+ private static boolean regionDefinitelyOnTheRegionServerException(Throwable
t) {
+ return (t instanceof RegionTooBusyException || t instanceof
RpcThrottlingException
+ || t instanceof RetryImmediatelyException || t instanceof
CallQueueTooBigException
+ || t instanceof CallDroppedException || t instanceof
RequestTooBigException);
Review comment:
But at least they do not mean the region is on the region server right? So
the method name here is confusing...
And I still have concerns about do not retry on these two exceptions. Maybe
we should not clear meta everytime, but as I said above, what if the region
server can not recover all the time but the region has been moved elsewhere?
The client will have no chance to update the meta?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
