[
https://issues.apache.org/jira/browse/HBASE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244491#comment-13244491
]
stack commented on HBASE-4393:
------------------------------
Please format your contrib as a patch (git or svn add then do a git diff
--no-prefix or svn diff). Thanks.
This line is not necessary any more:
{code}
* Copyright 2012 The Apache Software Foundation
{code}
Please fix this doc: ' * HBase Canary Tool, that that can be used to do' (too
many 'that's)
On the Sink interface, its not going to be used by anyone else if its private?
That might be fine for first checkin. Later when other Sinks we can open it up?
I think filesink is the wrong sink to do as first implementation. Your first
Sink should be StdOutSink using Logging system. Notice how anything that is
started with bin/hbase-daemon.sh gets log files set up for it (master,
regionserver, but also rest, thrift, etc.). Doing this, your emissions will be
in a well-known place in files that are named with a format that matches other
loggings made by hbase, etc.
This method is oddly named:
{code}
public void publish(HRegionInfo region, HColumnDescriptor column, long msTime)
{
{code}
It seems like its for logging messages like this: "%s read from region %s
column family %s in %dms\n",
... should method name be logReadTime? Or publishReadTiming?
Whats the BasicParser do? It matches what Tool does? We don't want GnuParser?
I like this comment:
{code}
// user has specified an interval for canary breaths
{code}
Thats cute.
Put on one line:
{code}
if (conf == null)
conf = HBaseConfiguration.create();
{code}
I think I should be able to run this once OR run it as a daemon. Pass an arg
if its to run as daemon process?
Can this code use any of the utility that is in hbck?
I like the Tool improvements.
Thanks Matteo.
> Implement a canary monitoring program
> -------------------------------------
>
> Key: HBASE-4393
> URL: https://issues.apache.org/jira/browse/HBASE-4393
> Project: HBase
> Issue Type: New Feature
> Components: monitoring
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Matteo Bertozzi
> Attachments: Canary-v0.java, HBaseCanary.java
>
>
> This JIRA is to implement a standalone program that can be used to do "canary
> monitoring" of a running HBase cluster. This program would gather a list of
> the regions in the cluster, then iterate over them doing lightweight
> operations (eg short scans) to provide metrics about latency as well as alert
> on availability issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
