saintstack commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r315275589
########## File path: hbase-hbtop/pom.xml ########## @@ -0,0 +1,59 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <!-- + /** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + --> + <modelVersion>4.0.0</modelVersion> + <parent> + <artifactId>hbase</artifactId> + <groupId>org.apache.hbase</groupId> + <version>3.0.0-SNAPSHOT</version> + </parent> + <artifactId>hbase-hbtop</artifactId> + <name>Apache HBase - HBTop</name> + <description>A real-time monitoring tool for HBase like Unix top command</description> Review comment: bq. ....because managing the compatibilities is much easier. Smile. This might not be a good argument for keeping hbtop in hbase. Being external in hbase-operator-tools, the change turnaround will be better, hbtop being able to run externally against public APIs will make for a more robust product I think -- robust against internal changes. hbase codebase is too big as is. Would be good to not add more if possible. You've done the hard work of putting it into its own module so export might be pretty smooth? But if you think it a PITA being out in hbase-operator-tools we could commit to hbase now and then move it out if you think that'll help speed dev. This is a nice feature. Would be good to get it in. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
