[ 
https://issues.apache.org/jira/browse/HBASE-22882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910752#comment-16910752
 ] 

Nick Dimiduk commented on HBASE-22882:
--------------------------------------

A test that fails in 90% of runs should not be suffered to live. It doesn't 
increase confidence in the code under test and presence in the code-base both 
makes builds take longer and will fake out static coverage analysis tools. I 
suggest its removal.

Looking back at HBASE-7536, it seems unlikely that an appeal to the 
contributing/reviewing dev(s) will produce a fix to the test. Let's just drop 
it.

> TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts is flakey (was 
> written flakey)
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-22882
>                 URL: https://issues.apache.org/jira/browse/HBASE-22882
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: stack
>            Assignee: stack
>            Priority: Major
>             Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>         Attachments: 22882.txt, Screen Shot 2019-08-19 at 12.46.33 PM.png, 
> Screen Shot 2019-08-19 at 12.46.33 PM.png
>
>
> See HBASE-7536 which adds this test. The author and reviewers note the 
> indeterminacy of the test. In branch-2.0 it fails 90% of the time on the GCE 
> runs. Disabling it. In the original issue, its noted that it would take a 
> bunch of work to make it deterministic. Meantime disabling it.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to