sunhelly commented on a change in pull request #512: HBASE-22881 Fix non-daemon
threads in hbase server implementation
URL: https://github.com/apache/hbase/pull/512#discussion_r316507725
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
##########
@@ -226,7 +226,8 @@ public FSHLog(final FileSystem fs, final Path rootDir,
final String logDir,
// Using BlockingWaitStrategy. Stuff that is going on here takes so long
it makes no sense
// spinning as other strategies do.
this.disruptor = new Disruptor<>(RingBufferTruck::new,
- getPreallocatedEventCount(),
Threads.getNamedThreadFactory(hostingThreadName + ".append"),
+ getPreallocatedEventCount(),
+ Threads.newDaemonThreadFactory(hostingThreadName + ".append"),
Review comment:
I have changed the title, and all UTs passed once in the next runs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
