Apache-HBase commented on issue #527: HBASE-22880 Move the DirScanPool out and do not use static field URL: https://github.com/apache/hbase/pull/527#issuecomment-524198641 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 101 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 6 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +1 | mvninstall | 521 | branch-1 passed | | +1 | compile | 50 | branch-1 passed | | +1 | checkstyle | 116 | branch-1 passed | | -1 | shadedjars | 17 | branch has 10 errors when building our shaded downstream artifacts. | | +1 | javadoc | 43 | branch-1 passed | | 0 | spotbugs | 165 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 162 | branch-1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 136 | the patch passed | | +1 | compile | 51 | the patch passed | | +1 | javac | 51 | the patch passed | | -1 | checkstyle | 117 | hbase-server: The patch generated 69 new + 255 unchanged - 5 fixed = 324 total (was 260) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 16 | patch has 10 errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 337 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 150 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8845 | hbase-server in the patch passed. | | +1 | asflicense | 42 | The patch does not generate ASF License warnings. | | | | 10908 | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/527 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 741633d74559 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh | | git revision | branch-1 / bb87e3a | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/artifact/out/branch-shadedjars.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/artifact/out/patch-shadedjars.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/testReport/ | | Max. process+thread count | 4037 (vs. ulimit of 10000) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
