[
https://issues.apache.org/jira/browse/HBASE-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244995#comment-13244995
]
[email protected] commented on HBASE-5444:
------------------------------------------------------
bq. On 2012-03-23 17:01:13, Jimmy Xiang wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/protobuf/MasterRegionInterface.java, line
34
bq. > <https://reviews.apache.org/r/4463/diff/1/?file=94838#file94838line34>
bq. >
bq. > Should it be Private? Should we call it MasterRegionProtocol?
bq.
bq. Gregory Chanan wrote:
bq. I'll make it private.
bq.
bq. I'll leave it named Interface for now, just because it is replacing
"HMasterRegionInterface." I agree we should be consistent. Perhaps someone
else can chime in with an opinion on Interface vs Protocol.
IMO, Protocol would be better. Interface is way overloaded. So is protocol
but less so and this seems like usage seems particularly apt. Just my twosense
(This was an old comment I never published)
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4463/#review6286
-----------------------------------------------------------
On 2012-03-23 19:55:28, Gregory Chanan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4463/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 19:55:28)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Adds PB-based calls replacing HMasterRegionInterface.
bq.
bq. There are some temporary hacks, e.g. converting PB-based ServerLoad to
existing HServerLoad so I didn't need to convert ClusterStatus (which brings in
a lot of other changes). That will be cleaned up in HBASE-5445.
bq.
bq.
bq. This addresses bug HBASE-5444.
bq. https://issues.apache.org/jira/browse/HBASE-5444
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml 10b13ef
bq.
src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
69434f7
bq.
src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
ae76204
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 9df4c10
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java 8888347
bq. src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
cbfa489
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 0db2760
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 2916d68
bq. src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java
fd97830
bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java f1f06b0
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
d47ef10
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java cd1755f
bq. src/main/java/org/apache/hadoop/hbase/master/MXBean.java 7f44dc2
bq. src/main/java/org/apache/hadoop/hbase/master/MXBeanImpl.java 45b8fe7
bq. src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java
be63838
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java cbd55f7
bq.
src/main/java/org/apache/hadoop/hbase/protobuf/MasterRegionInterface.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/protobuf/PBHelper.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
e0af8fb
bq. src/main/proto/MasterRegionProtocol.proto PRE-CREATION
bq. src/main/proto/hbase.proto PRE-CREATION
bq. src/main/resources/hbase-webapps/master/table.jsp 811df46
bq. src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 6af9188
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
368a0e5
bq. src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
f2f8ee3
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
841649a
bq. src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java 379f70c
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
e99d251
bq.
bq. Diff: https://reviews.apache.org/r/4463/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran jenkins job, all unit tests passed.
bq.
bq.
bq. Thanks,
bq.
bq. Gregory
bq.
bq.
> Add PB-based calls to HMasterRegionInterface
> --------------------------------------------
>
> Key: HBASE-5444
> URL: https://issues.apache.org/jira/browse/HBASE-5444
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Todd Lipcon
> Assignee: Gregory Chanan
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
