infraio commented on a change in pull request #498: HBASE-22819 Automatically
migrate the rs group config for table after…
URL: https://github.com/apache/hbase/pull/498#discussion_r317335888
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupUtil.java
##########
@@ -34,24 +34,29 @@
private RSGroupUtil() {
}
- @FunctionalInterface
- private interface GetRSGroup {
- RSGroupInfo get(String groupName) throws IOException;
- }
-
- private static Optional<RSGroupInfo> getRSGroupInfo(MasterServices master,
GetRSGroup getter,
+ /**
+ * Will try to get the rsgroup from {@link TableDescriptor} first, and then
try to get the rsgroup
+ * from the {@link NamespaceDescriptor}. If still not present, return empty.
Review comment:
Seems the impl didn't get rsgroup from NamespaceDescriptor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
