busbey commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r317643220
########## File path: bin/hbase ########## @@ -656,6 +656,8 @@ elif [ "$COMMAND" = "pre-upgrade" ] ; then CLASS='org.apache.hadoop.hbase.tool.PreUpgradeValidator' elif [ "$COMMAND" = "completebulkload" ] ; then CLASS='org.apache.hadoop.hbase.tool.BulkLoadHFilesTool' +elif [ "$COMMAND" = "top" ] ; then Review comment: can this command use either the `hbase-shaded-client` or `hbase-shaded-mapreduce` instead of the internal calsspath? see the logic starting around line 225 in the as-of-now version of your fork. starts with `# If command can use our shaded client, use it` followed by the section `# If command needs our shaded mapreduce, use it`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
