[
https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245737#comment-13245737
]
jirapos...@reviews.apache.org commented on HBASE-5707:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4627/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Move two more znodes to serialize their content as pb.
Here are the changes:
{code}
M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
Get the clusterid via utility in the ClusterId class rather than
get it directly.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterId.java
M src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java
Serialize and deserialize using new ClusterId pb message.
Include the PBUF preamble on znode content.
M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
Rename getRootRegionZNodeContent to getZNodeData so it aligns in name
with the other cases where we compose the znode content up in ClusterId
and in ClusterStatusTracker.
M src/main/protobuf/ZooKeeper.proto
Add new messages for ClusterId and ClusterUp
{code}
This addresses bug hbase-5707.
https://issues.apache.org/jira/browse/hbase-5707
Diffs
-----
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969
src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
8ff87fe
src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterId.java 3fa83e6
src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java
61e7367
src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
6b2ea57
src/main/protobuf/ZooKeeper.proto 20f8eb0
Diff: https://reviews.apache.org/r/4627/diff
Testing
-------
Thanks,
Michael
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5707.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
