saintstack commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-525369689 @brfrn169 On my two concerns, that we use a 3rd party terminal/libs instead of writing our own and whether it should be out in hbase-operator-tools or committed into hbase, it seems like others are not too concerned on #1 and as you've said above, if we find a terminal ilb, you've made it so it can be slotted in in place of your Terminal class. On the second issue, @busbey above points out that if this is in hbase-operator-tools, there will be a lower barrier to commit, you'll not have to do a load of backporting across hbase versions as you fix stuff. and dev should run faster being apart from the main codebase. Downsides are it'd be awkward doing 'hbase hbtop'...etc. What you thinking these times sir? Would it help if we committed on hbase-operator-tools, and soon after made a release that mainline hbase depended on? Would this help? Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
