[ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245862#comment-13245862
 ] 

jirapos...@reviews.apache.org commented on HBASE-5645:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4612/
-----------------------------------------------------------

(Updated 2012-04-03 22:54:54.016499)


Review request for hbase.


Changes
-------

Corrected JIRA number.


Summary (updated)
-------

Fixes for issues reported in findbugs for "Correctness" category.


This addresses bug HBASE-5645.
    https://issues.apache.org/jira/browse/HBASE-5645


Diffs
-----

  dev-support/test-patch.properties 2209d27 
  src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon 
ae76204 
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 37bcaba 
  src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 32d66fb 
  src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 64def15 
  src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832 
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java 9bd4ace 
  src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 3515d4a 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 8ae60a3 
  src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897 
  src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java e3b230e 
  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 0c7b396 
  src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 2e98b39 
  src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d 
  
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
 8950c9f 
  src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac 
  src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0 
  src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c 
  src/main/java/org/apache/hadoop/hbase/util/Merge.java 04f15d4 
  src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856 

Diff: https://reviews.apache.org/r/4612/diff


Testing
-------

Ran test-patch.sh and unit tests.


Thanks,

David


                
> [findbugs] Fix correctness warnings
> -----------------------------------
>
>                 Key: HBASE-5645
>                 URL: https://issues.apache.org/jira/browse/HBASE-5645
>             Project: HBase
>          Issue Type: Sub-task
>          Components: scripts
>            Reporter: Jonathan Hsieh
>            Assignee: David S. Wang
>         Attachments: HBASE-5645.patch
>
>
> See 
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to