[
https://issues.apache.org/jira/browse/HBASE-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245893#comment-13245893
]
[email protected] commented on HBASE-5709:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4630/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Serialize active master using pb. Do same for backup masters.
D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java
Moved under zookeeper. All other Trackers are under zookeeper but this one.
M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
Use new utility method for getting current master that is over in
MasterAddressTracker.
M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
Move dup code out into a new handle function.
watcher.masterAddressZNode is no longer public. Use accessor.
Use new setMasterAddress,getMasterAddress function on
MasterAddressTracker for setting znode and backup master znode.
M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
Generated code.
M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Fix up import because MasterAddressTracker moved.
A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
Add back MasterAddressTracker here. Add some utility functions for setting
and getting the master address.
M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
Move dataToServerName into ZKUtil. Its useful beyond this class only.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
Go via accessor to get master znode path and use new utility method
to get current master address. dataToServerName moved here from
RootRegionTracker.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
Shutdown access to masterAddressZNode. Add an accessor method.
M src/main/protobuf/ZooKeeper.proto
Add new master message class.
M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
M
src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java
Go via new accessor and use utility over in MasterAddressTracker.
M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
Fix import to point at new location.
This addresses bug hbase-5709.
https://issues.apache.org/jira/browse/hbase-5709
Diffs
-----
src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969
src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9
src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
8ff87fe
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999
src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
6b2ea57
src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354
src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655
src/main/protobuf/ZooKeeper.proto 20f8eb0
src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
05f6b1a
src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java
e91d83c
src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
8478260
Diff: https://reviews.apache.org/r/4630/diff
Testing
-------
Thanks,
Michael
> Move active master and backup master znodes to use pbs
> ------------------------------------------------------
>
> Key: HBASE-5709
> URL: https://issues.apache.org/jira/browse/HBASE-5709
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Attachments: 5709.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
