Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode URL: https://github.com/apache/hbase/pull/528#discussion_r319440400
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java ########## @@ -1029,19 +1053,23 @@ private void persistToFile() throws IOException { } fos = new FileOutputStream(persistencePath, false); oos = new ObjectOutputStream(fos); + oos.writeLong(-1); Review comment: HBase has a PB_MAGIC_STR in `ProtobufUtil`, I suggest use that instead of `-1`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services