shahrs87 commented on a change in pull request #565: [HBASE-22874] Canary 
should not be IA.Public
URL: https://github.com/apache/hbase/pull/565#discussion_r319691798
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
 ##########
 @@ -843,9 +876,9 @@ public int run(String[] args) throws Exception {
               }
             }
             currentTimeLength = System.currentTimeMillis() - startTime;
-            if (currentTimeLength > this.timeout) {
+            if (currentTimeLength > timeout) {
 
 Review comment:
   I removed bunch of class variables and store them in conf object.  I 
replaced the class variable with method local variable. So I can't use "this" 
anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to