Apache9 commented on a change in pull request #565: [HBASE-22874] Canary should not be IA.Public URL: https://github.com/apache/hbase/pull/565#discussion_r319760018
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryInterface.java ########## @@ -0,0 +1,57 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.tool; + + +import org.apache.hadoop.conf.Configuration; +import org.apache.yetus.audience.InterfaceAudience; + +import java.util.concurrent.ExecutorService; + [email protected] +public interface CanaryInterface { + + static CanaryInterface create(Configuration conf, ExecutorService executor) { + return new Canary(conf, executor); + } + + /** + * Run Canary in Region mode. + * @param targets -- list of monitor tables. + * @return the exit code of the Canary tool. + * @throws Exception + */ + public int runRegionCanary(String[] targets) throws Exception; + + /** + * Runs Canary in Region server mode. + * @param targets -- list of monitor tables. + * @return the exit code of the Canary tool. + * @throws Exception + */ + public int runRegionServerCanary(String[] targets) throws Exception; + + /** + * Runs Canary in Zookeeper mode. + * @return the exit code of the Canary tool. + * @throws Exception + */ + public int runZookeeperCanary() throws Exception; Review comment: Call it checkZooKeeper? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
