[ 
https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246574#comment-13246574
 ] 

Nicolas Spiegelberg commented on HBASE-5359:
--------------------------------------------

The only worry that I have with this patch is that I have an unconditional 
wait.  The code should theoretically be fine because the main problem would be 
handling a shutdownNow() request.  In this case, it should throw an 
InterruptException and be released by the finally block that Ted mentions.  
However, a bug would cause the RPC thread (and, hence, the RS) to hang and 
avoid exiting.  That said, adding a time on the wait might end up masking a bug 
and cause the shutdown process to appear hacky.
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where 
> it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler 
> is able call AM.setRegionsToReopen so that the returned status shows no 
> pending regions. It means that the alter seems "instantaneous" although it's 
> far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to