wchevreuil commented on a change in pull request #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta URL: https://github.com/apache/hbase-operator-tools/pull/18#discussion_r320174344
########## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ########## @@ -88,6 +100,10 @@ private static final String VERSION = "version"; private static final String SET_REGION_STATE = "setRegionState"; private static final String SCHEDULE_RECOVERIES = "scheduleRecoveries"; + private static final String ADD_MISSING_REGIONS_IN_META_FOR_TABLES = + "addMissingRegionsInMetaForTables"; + private static final String ADD_MISSING_REGIONS_IN_META = "addMissingRegionsInMeta"; + private static final String REPORT_MISSING_REGIONS_IN_META = "reportMissingRegionsInMeta"; Review comment: This is following the "plumbing" vs "porcelain" approach discussed on previous [PR here](https://github.com/apache/hbase-operator-tools/pull/3#pullrequestreview-248845719), where we provide a simpler usage, convenient method that does all the inserts for specified tables (addMissingRegionsInMetaForTable), but we also give extra options for more advanced users to inspect on troubled regions (reportMissingRegionsInMeta) and maybe decide which specific regions need to be added, individually or grouped (addMissingRegionsInMeta). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
