joshelser commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-527484805
 
 
   > Regarding the issue where the byte-sizes don't get rolled up to the next 
unit, I added a logic to do it in FieldValue
   
   Looks good!
   
   > I made Record class immutable in the latest commit.
   
   Left a new comment (throw UnsupportedOperationException instead of letting 
it throw an exception via the `ImmutableMap`), but that doesn't need to block 
getting this in.
   
   If we think this is ready to go, I'll test it locally again. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to