joshelser commented on a change in pull request #570: HBASE-22013 SpaceQuotas -
getNumRegions() returning wrong number of regions due to region replicas
URL: https://github.com/apache/hbase/pull/570#discussion_r320882392
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaObserverChore.java
##########
@@ -764,6 +765,9 @@ int getNumRegions(TableName table) throws IOException {
List<RegionInfo> regions = this.conn.getAdmin().getRegions(table);
if (regions == null) {
return 0;
+ } else {
Review comment:
Nit: the `else` branch is unnecessary. Just make this `if (regions==null)
{return 0;} RegionReplicaUtil...` (but properly formatted).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
