symat commented on a change in pull request #394: HBASE-22716:upgrade zookeeper
version to 3.5.5
URL: https://github.com/apache/hbase/pull/394#discussion_r316576357
##########
File path: pom.xml
##########
@@ -1471,7 +1471,7 @@
<protobuf.plugin.version>0.5.0</protobuf.plugin.version>
<thrift.path>thrift</thrift.path>
<thrift.version>0.12.0</thrift.version>
- <zookeeper.version>3.4.10</zookeeper.version>
+ <zookeeper.version>3.5.5</zookeeper.version>
<!-- What ZooKeeper 3.4.x depends on and nothing more -->
<jline.version>0.9.94</jline.version>
Review comment:
should we also update the jline version? I think it was added because of
zookeeper, see https://issues.apache.org/jira/browse/HBASE-20108
zookeeper 3.5.5 is using jline 2.11
however, if we increment the JLine version, then the assembly:single maven
target will fail, as the license part in JLine pom changed a bit (they named it
'The BSD License' instead of 'BSD License'). To make it work, we need to add a
new supplement to `supplemental-models.xml` like:
```
<supplement>
<project>
<groupId>jline</groupId>
<artifactId>jline</artifactId>
<name>JLine</name>
<version>2.11</version>
<licenses>
<license>
<name>BSD License</name>
<url>http://www.opensource.org/licenses/bsd-license.php</url>
<distribution>repo</distribution>
</license>
</licenses>
</project>
</supplement>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
