[
https://issues.apache.org/jira/browse/HBASE-22937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923734#comment-16923734
]
Hudson commented on HBASE-22937:
--------------------------------
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #634 (See
[https://builds.apache.org/job/HBase-1.3-IT/634/])
HBASE-22937 The RawBytesComparator in branch-1 have wrong comparison (apurtell:
rev 6dd891447c8456849c2389146e9ba9050f5a59b0)
* (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
> The RawBytesComparator in branch-1 have wrong comparison order
> --------------------------------------------------------------
>
> Key: HBASE-22937
> URL: https://issues.apache.org/jira/browse/HBASE-22937
> Project: HBase
> Issue Type: Bug
> Reporter: Zheng Hu
> Assignee: Zheng Hu
> Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
>
> When digging the HBASE-22862, we found a bug in
> RawBytesComparator#compareOnlyKeyPortion (although it's unrelated to the
> corruption in HBASE-22862).
> {code}
> @Override
> @VisibleForTesting
> public int compareOnlyKeyPortion(Cell left, Cell right) {
> // ...
> return (0xff & left.getTypeByte()) - (0xff & right.getTypeByte());
> }
> {code}
> Here should be (0xff & right.getTypeByte()) - (0xff & left.getTypeByte()) I
> think.
> I can see the BloomFilter or HFile v2 are still using the comparator in
> branch-1 (but not in branch-2). Maybe we can just remove the class (if some
> HFile encoded with this comparator, then mapping to the correct KVComparator
> just like 2.x), or fix the bug in current RawBytesComparator.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
