[ https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923914#comment-16923914 ]
Anoop Sam John commented on HBASE-22930: ---------------------------------------- Sorry for being later in replying to u [~pankaj2461].. Yes my comment was on the usage of the local Atomic variable usage. The pull request #585 looks good. You want fix this in branch-1 also? There seems we are not even using google common ThreadFactoryBuilder so own Atomic variable usage might be needed. Its ok to fix this in branch-2 + also. > Set unique name to longCompactions/shortCompactions threads > ----------------------------------------------------------- > > Key: HBASE-22930 > URL: https://issues.apache.org/jira/browse/HBASE-22930 > Project: HBase > Issue Type: Improvement > Reporter: Pankaj Kumar > Assignee: Pankaj Kumar > Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > Sometime observed multiple compaction threads have the same name which is > misleading while analysing the log. > Currently we just append the current timestamp which can be same for multiple > threads, > [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144] -- This message was sent by Atlassian Jira (v8.3.2#803003)