shardul-cr7 commented on a change in pull request #571: HBASE-20821 Re-creating
a dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r321589810
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotasObserver.java
##########
@@ -78,6 +79,20 @@ public void postDeleteTable(
admin.setQuota(settings);
}
}
+ } else if (quotasAtNamespace != null) {
+ // If quota present at namespace level remove the table entry from
'hbase:quota'
Review comment:
Hi Josh, thanks for the review , I have one doubt.
1. create namespace with quota.
2. create table.
3. violate quota on the namespace by puting data into the table.
4. delete the table.
5. create another table with same name inside namespace.
6. Currently , table will be in violation even though it doesn't have any
data in it since it's entry was not deleted from 'hbase:quota'.
Is this the intended behaviour?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
