shardul-cr7 commented on a change in pull request #570: HBASE-22013 SpaceQuotas - getNumRegions() returning wrong number of regions due to region replicas URL: https://github.com/apache/hbase/pull/570#discussion_r321709080
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotasWithRegionReplicas.java ########## @@ -0,0 +1,119 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.quotas; + +import java.util.concurrent.atomic.AtomicLong; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HBaseClassTestRule; +import org.apache.hadoop.hbase.HBaseTestingUtility; +import org.apache.hadoop.hbase.NamespaceDescriptor; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.Put; +import org.apache.hadoop.hbase.testclassification.MediumTests; +import org.apache.hadoop.hbase.util.Bytes; +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.rules.TestName; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +@Category(MediumTests.class) +public class TestSpaceQuotasWithRegionReplicas { + + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestSpaceQuotasWithRegionReplicas.class); + + private static final Logger LOG = + LoggerFactory.getLogger(TestSpaceQuotasWithRegionReplicas.class); + private static final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); + private static final int NUM_RETRIES = 10; + + @Rule + public TestName testName = new TestName(); + private SpaceQuotaHelperForTests helper; + + @BeforeClass + public static void setUp() throws Exception { + Configuration conf = TEST_UTIL.getConfiguration(); + SpaceQuotaHelperForTests.updateConfigForQuotas(conf); + TEST_UTIL.startMiniCluster(1); + } + + @AfterClass + public static void tearDown() throws Exception { + TEST_UTIL.shutdownMiniCluster(); + } + + @Before + public void removeAllQuotas() throws Exception { + helper = new SpaceQuotaHelperForTests(TEST_UTIL, testName, new AtomicLong(0)); + helper.removeAllQuotas(); + } + + @Test + public void testSetQuotaWithRegionReplicaSingleRegion() throws Exception { + setQuotaAndVerifyForRegionReplication(1, 2, SpaceViolationPolicy.NO_INSERTS); + setQuotaAndVerifyForRegionReplication(1, 2, SpaceViolationPolicy.NO_WRITES); + setQuotaAndVerifyForRegionReplication(1, 2, SpaceViolationPolicy.NO_WRITES_COMPACTIONS); + setQuotaAndVerifyForRegionReplication(1, 2, SpaceViolationPolicy.DISABLE); + } + + @Test + public void testSetQuotaWithRegionReplicaMultipleRegion() throws Exception { + setQuotaAndVerifyForRegionReplication(5, 3, SpaceViolationPolicy.NO_INSERTS); + setQuotaAndVerifyForRegionReplication(6, 3, SpaceViolationPolicy.NO_WRITES); + setQuotaAndVerifyForRegionReplication(6, 3, SpaceViolationPolicy.NO_WRITES_COMPACTIONS); + setQuotaAndVerifyForRegionReplication(6, 3, SpaceViolationPolicy.DISABLE); + } + + @Test + public void testSetQuotaWithSingleRegionZeroRegionReplica() throws Exception { + setQuotaAndVerifyForRegionReplication(1, 0, SpaceViolationPolicy.NO_INSERTS); + setQuotaAndVerifyForRegionReplication(1, 0, SpaceViolationPolicy.NO_WRITES); + setQuotaAndVerifyForRegionReplication(1, 0, SpaceViolationPolicy.NO_WRITES_COMPACTIONS); + setQuotaAndVerifyForRegionReplication(1, 0, SpaceViolationPolicy.DISABLE); + } + + @Test + public void testSetQuotaWithMultipleRegionZeroRegionReplicas() throws Exception { + setQuotaAndVerifyForRegionReplication(5, 0, SpaceViolationPolicy.NO_INSERTS); + setQuotaAndVerifyForRegionReplication(6, 0, SpaceViolationPolicy.NO_WRITES); + setQuotaAndVerifyForRegionReplication(6, 0, SpaceViolationPolicy.NO_WRITES_COMPACTIONS); + setQuotaAndVerifyForRegionReplication(6, 0, SpaceViolationPolicy.DISABLE); + } + + private void setQuotaAndVerifyForRegionReplication(int region, int replicatedRegion, + SpaceViolationPolicy policy) throws Exception { + TableName tn = helper.createTableWithRegions(TEST_UTIL.getAdmin(), + NamespaceDescriptor.DEFAULT_NAMESPACE_NAME_STR, region, replicatedRegion); + helper.setQuotaLimit(tn, policy, 5L); + helper.writeData(tn, 5L * SpaceQuotaHelperForTests.ONE_MEGABYTE); + Put p = new Put(Bytes.toBytes("to_reject")); + p.addColumn(Bytes.toBytes(SpaceQuotaHelperForTests.F1), Bytes.toBytes("to"), + Bytes.toBytes("reject")); + // Adding a sleep for 5 sec, so all the chores run and to void flakiness of the test. + Thread.sleep(5000); Review comment: Not required here since verifyViolation() has NUM_RETRIES as 10 and also has some wait. So removing the Thread.Sleep here. Even without it, testcase will always pass. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
