[
https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924886#comment-16924886
]
Duo Zhang commented on HBASE-11062:
-----------------------------------
https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/583/artifact/output-general/patch-compile-root.txt
{quote}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile)
on project hbase-hbtop: Compilation failure: Compilation failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2.2/component/hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/impl/KeyPressGenerator.java:[147,8]
error: [MissingDefault] The Google Java Style Guide requires that each switch
statement includes a default statement group, even if it contains no code.
(This requirement is lifted for any switch statement that covers all values of
an enum.)
[ERROR] (see https://errorprone.info/bugpattern/MissingDefault)
[ERROR] Did you mean 'continue;'?
[ERROR]
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2.2/component/hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/field/FieldScreenView.java:[95,4]
error: [MissingDefault] The Google Java Style Guide requires that each switch
statement includes a default statement group, even if it contains no code.
(This requirement is lifted for any switch statement that covers all values of
an enum.)
[ERROR] (see https://errorprone.info/bugpattern/MissingDefault)
[ERROR] Did you mean 'return fieldScreenPresenter.transitionToNextScreen();'?
[ERROR]
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2.2/component/hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/mode/ModeScreenView.java:[88,4]
error: [MissingDefault] The Google Java Style Guide requires that each switch
statement includes a default statement group, even if it contains no code.
(This requirement is lifted for any switch statement that covers all values of
an enum.)
[ERROR] (see https://errorprone.info/bugpattern/MissingDefault)
[ERROR] Did you mean 'return
modeScreenPresenter.transitionToNextScreen(false);'?
[ERROR] -> [Help 1]
[ERROR]
{quote}
Seems we break several error prone rules and fail the compile?
> hbtop
> -----
>
> Key: HBASE-11062
> URL: https://issues.apache.org/jira/browse/HBASE-11062
> Project: HBase
> Issue Type: New Feature
> Components: hbtop
> Reporter: Andrew Purtell
> Assignee: Toshihiro Suzuki
> Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> A top-like monitor could be useful for testing, debugging, operations of
> clusters of moderate size, and possibly for diagnosing issues in large
> clusters.
> Consider a curses interface like the one presented by atop
> (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate
> metrics collected over a monitoring interval in the upper portion of the
> pane, and a listing of discrete measurements sorted and filtered by various
> criteria in the bottom part of the pane. One might imagine a cluster overview
> with cluster aggregate metrics above and a list of regionservers sorted by
> utilization below; and a regionserver view with process metrics above and a
> list of metrics by operation type below, or a list of client connections, or
> a list of threads, sorted by utilization, throughput, or latency.
> Generically 'htop' is taken but would be distinctive in the HBase context, a
> utility org.apache.hadoop.hbase.HTop
> No need necessarily for a curses interface. Could be an external monitor with
> a web front end as has been discussed before. I do like the idea of a process
> that runs in a terminal because I interact with dev and test HBase clusters
> exclusively by SSH.
> UPDATE:
> The tool name is changed from htop to hbtop.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
