busbey commented on a change in pull request #566: HBASE-22380 break circle
replication when doing bulkload
URL: https://github.com/apache/hbase/pull/566#discussion_r323462663
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
##########
@@ -579,9 +579,9 @@ public static BulkLoadHFileRequest
buildBulkLoadHFileRequest(
* @return a bulk load request
*/
public static BulkLoadHFileRequest buildBulkLoadHFileRequest(
- final List<Pair<byte[], String>> familyPaths,
- final byte[] regionName, boolean assignSeqNum,
- final Token<?> userToken, final String bulkToken, boolean copyFiles) {
+ final List<Pair<byte[], String>> familyPaths, final byte[] regionName,
boolean assignSeqNum,
+ final Token<?> userToken, final String bulkToken, boolean copyFiles,
+ List<String> clusterIds) {
Review comment:
I agree keeping UUIDs until serialization would be nicer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
