[ 
https://issues.apache.org/jira/browse/HBASE-22988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928068#comment-16928068
 ] 

Andrew Purtell commented on HBASE-22988:
----------------------------------------

Not sure your addendum changes are included here. I used your github branch as 
source. 

bq. Do we need to convert the patch to for java7? If so, I can do it.

It would make adoption easier. Right now we must conditionally include the 
module only if building with java 8 and there are issues with precommit for 
this configuration. If it were all Java 7 code then we can include the module 
unconditionally. The issues with the unit tests would also be resolved. Let’s 
do this if you have the time and interest. 

I will be back from vacation in two weeks. Happy to review or help out when 
back if needed. 

> Backport HBASE-11062 "hbtop" to branch-1
> ----------------------------------------
>
>                 Key: HBASE-22988
>                 URL: https://issues.apache.org/jira/browse/HBASE-22988
>             Project: HBase
>          Issue Type: Sub-task
>          Components: backport, hbtop
>            Reporter: Toshihiro Suzuki
>            Assignee: Andrew Purtell
>            Priority: Major
>             Fix For: 1.5.0
>
>         Attachments: HBASE-22988-branch-1.patch
>
>
> Backport parent issue to branch-1.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to