ramkrish86 commented on a change in pull request #528: HBASE-22890 Verify the 
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r323554877
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
 ##########
 @@ -267,6 +318,98 @@ void refreshFileConnection(int accessFileNum, IOException 
ioe) throws IOExceptio
     }
   }
 
+  @Override
+  public byte[] readPersistenceChecksum(String persistencePath) {
 
 Review comment:
   this can be called readPersistentCheckSum(). But do we need this API. 
Instead can we just do this internally under verifyCheckSum() or 
verifyFileIntegrity()?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to