busbey commented on a change in pull request #616: HBASE-23015 : Moving from
Jackson2 to shaded Gson
URL: https://github.com/apache/hbase/pull/616#discussion_r323767796
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/http/jmx/JMXJsonServlet.java
##########
@@ -163,14 +163,14 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response) thro
try {
jsonpcb = checkCallbackName(request.getParameter(CALLBACK_PARAM));
writer = response.getWriter();
- beanWriter = this.jsonBeanWriter.open(writer);
// "callback" parameter implies JSONP outpout
if (jsonpcb != null) {
response.setContentType("application/javascript; charset=utf8");
writer.write(jsonpcb + "(");
} else {
response.setContentType("application/json; charset=utf8");
}
+ beanWriter = this.jsonBeanWriter.open(writer);
Review comment:
why did this need to move down?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
