virajjasani commented on a change in pull request #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#discussion_r324038075
########## File path: hbase-testing-util/pom.xml ########## @@ -164,6 +164,11 @@ </exclusion> </exclusions> </dependency> + <dependency> + <groupId>org.codehaus.jackson</groupId> Review comment: hbase-testing-util is used for running unit tests only by downstreamers? like just to bring up HBase minicluster by downstreamers and run their own tests on top of it? if no, then let me change this to `compile` Edit: I think better to include at `compile` given downstreames requirement ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services