Apache-HBase commented on issue #623: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/623#issuecomment-531440787 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | :blue_heart: | reexec | 2m 24s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 9 new or modified test files. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 6m 46s | master passed | | :green_heart: | compile | 1m 4s | master passed | | :green_heart: | checkstyle | 1m 43s | master passed | | :green_heart: | shadedjars | 5m 30s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 43s | master passed | | :blue_heart: | spotbugs | 4m 56s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 53s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 6m 10s | the patch passed | | :green_heart: | compile | 1m 9s | the patch passed | | :green_heart: | javac | 1m 9s | the patch passed | | :broken_heart: | checkstyle | 1m 42s | hbase-server: The patch generated 48 new + 239 unchanged - 42 fixed = 287 total (was 281) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 47s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 19m 47s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :broken_heart: | javadoc | 0m 40s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | :broken_heart: | findbugs | 4m 51s | hbase-server generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) | ||| _ Other Tests _ | | :broken_heart: | unit | 300m 11s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. | | | | 371m 38s | | | Reason | Tests | |-------:|:------| | FindBugs | module:hbase-server | | | Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.master.MobFileCompactionChore.chore() At MobFileCompactionChore.java:is not thrown in org.apache.hadoop.hbase.master.MobFileCompactionChore.chore() At MobFileCompactionChore.java:[line 106] | | | org.apache.hadoop.hbase.mob.FileSelection defines compareTo(FileSelection) and uses Object.equals() At DefaultMobStoreCompactor.java:Object.equals() At DefaultMobStoreCompactor.java:[lines 614-619] | | | org.apache.hadoop.hbase.mob.Generation defines compareTo(Generation) and uses Object.equals() At DefaultMobStoreCompactor.java:Object.equals() At DefaultMobStoreCompactor.java:[lines 789-794] | | | Unused field:DefaultMobStoreCompactor.java | | | org.apache.hadoop.hbase.mob.Generations.build(List, Configuration) makes inefficient use of keySet iterator instead of entrySet iterator At DefaultMobStoreCompactor.java:of keySet iterator instead of entrySet iterator At DefaultMobStoreCompactor.java:[line 677] | | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.regionserver.TestMobStoreCompaction | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient | | | hadoop.hbase.util.TestHBaseFsckMOB | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.replication.TestReplicationSmallTests | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-623/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/623 | | JIRA Issue | HBASE-22749 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3269e41ac01f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-623/out/precommit/personality/provided.sh | | git revision | master / 1dcc8ee50c | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-623/1/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-623/1/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-623/1/artifact/out/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-623/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-623/1/testReport/ | | Max. process+thread count | 5065 (vs. ulimit of 10000) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-623/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services