saintstack commented on a change in pull request #578: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/578#discussion_r324429838
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##########
@@ -87,15 +96,15 @@ public static Throwable findException(Object exception) {
}
Throwable cur = (Throwable) exception;
while (cur != null) {
- if (isSpecialException(cur)) {
+ if (isExceptionWeCare(cur)) {
Review comment:
Ok. Good. isSpecialException is an awful name. isExceptionWeCare is too but
you made it private and it is only used here so its ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
