saintstack commented on a change in pull request #544: HBASE-22917 Proc-WAL
roll fails saying someone else has already created log
URL: https://github.com/apache/hbase/pull/544#discussion_r319814312
##########
File path:
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
##########
@@ -423,7 +423,7 @@ public void recoverLease() throws IOException {
// Create new state-log
if (!rollWriter(flushLogId + 1)) {
// someone else has already created this log
- LOG.debug("Someone else has already created log {}. Retrying.",
flushLogId);
+ LOG.debug("Someone else has already created log {}. Retrying.",
flushLogId + 1);
Review comment:
I had a review done a while ago but forgot to submit then I lost it!
IIRC, suggested doing the flushLogId + 1 into a new variable and then using
that rather than increment in two places. IIRC, there is another place after
this that needs the +1 done to it too.. or what we log is flushLogId w/o +1
when it should have +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
