Reidddddd commented on a change in pull request #615: HBASE-22975 Add read and 
write QPS metrics at server level and table level
URL: https://github.com/apache/hbase/pull/615#discussion_r324559157
 
 

 ##########
 File path: 
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableLatencies.java
 ##########
 @@ -16,13 +16,14 @@
  */
 package org.apache.hadoop.hbase.regionserver;
 
+import org.apache.hadoop.hbase.metrics.BaseSource;
 import org.apache.yetus.audience.InterfaceAudience;
 
 /**
  * Latency metrics for a specific table in a RegionServer.
  */
 @InterfaceAudience.Private
-public interface MetricsTableLatencies {
+public interface MetricsTableLatencies extends BaseSource {
 
 Review comment:
   MetricsTableLatencies extends BaseSourceImpl which implements BaseSource.
   Can't see the reason why MetricsTableLatencies extends this interface, again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to