langdamao commented on a change in pull request #554: HBASE-22887 Fix
HFileOutputFormat2 writer roll
URL: https://github.com/apache/hbase/pull/554#discussion_r324589031
##########
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
##########
@@ -286,12 +286,9 @@ public void write(ImmutableBytesWritable row, V cell)
configureStoragePolicy(conf, fs, tableAndFamily, writerPath);
}
- if (wl != null && wl.written + length >= maxsize) {
- this.rollRequested = true;
- }
-
// This can only happen once a row is finished though
- if (rollRequested && Bytes.compareTo(this.previousRow, rowKey) != 0) {
+ if (wl != null && wl.written + length >= maxsize
Review comment:
> Make a method that checks null and written length since you have this text
twice now?
Sorry，this only appear in this line once，I haven't found the second line？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
