chenxu14 commented on a change in pull request #581: HBASE-22888 Use separate
classe to deal with streaming read and pread
URL: https://github.com/apache/hbase/pull/581#discussion_r324625788
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
##########
@@ -164,13 +158,14 @@ public boolean isEmpty() {
@Override
public BlockWithScanInfo loadDataBlockWithScanInfo(Cell key, HFileBlock
currentBlock,
boolean cacheBlocks, boolean pread, boolean isCompaction,
- DataBlockEncoding expectedDataBlockEncoding) throws IOException {
+ DataBlockEncoding expectedDataBlockEncoding,
+ CachingBlockReader cachingBlockReader) throws IOException {
Review comment:
CellBasedKeyBlockIndexReader will use this, add it as parameter in order to
make BlockIndexReader stateless, so we can share it between readers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
