saintstack commented on a change in pull request #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#discussion_r324877767
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/ClientTokenUtil.java ########## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.security.token; + +import com.google.protobuf.ByteString; +import com.google.protobuf.ServiceException; +import java.io.IOException; +import java.lang.reflect.UndeclaredThrowableException; +import java.security.PrivilegedExceptionAction; +import java.util.concurrent.CompletableFuture; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.AsyncConnection; +import org.apache.hadoop.hbase.client.AsyncTable; +import org.apache.hadoop.hbase.client.Connection; +import org.apache.hadoop.hbase.client.Table; +import org.apache.hadoop.hbase.ipc.CoprocessorRpcChannel; +import org.apache.hadoop.hbase.protobuf.generated.AuthenticationProtos; +import org.apache.hadoop.hbase.security.User; +import org.apache.hadoop.io.Text; +import org.apache.hadoop.security.token.Token; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil; + +/** + * Utility methods for obtaining authentication tokens, that do not require hbase-server. + */ +@InterfaceAudience.Public +public final class ClientTokenUtil { + private static final Logger LOG = LoggerFactory.getLogger(ClientTokenUtil.class); + + // Set in TestClientTokenUtil via reflection + private static ServiceException injectedException; + + private ClientTokenUtil() {} + + private static void injectFault() throws ServiceException { + if (injectedException != null) { + throw injectedException; + } + } + + /** + * Obtain and return an authentication token for the current user. + * @param conn The async HBase cluster connection + * @return the authentication token instance, wrapped by a {@link CompletableFuture}. + */ + @InterfaceAudience.Private + public static CompletableFuture<Token<AuthenticationTokenIdentifier>> obtainToken( Review comment: The audience annotations are for downstreamers, not for hbase internally. Given ClientTokenUtil is a new class, we have opportunity for setting access as we see fit. The #toToken methods are used internal to the package only it seems (tests and the class-itself). Suggest these become package private or private especially the overrides that take protobufs. Otherwise, methods seem innocuous-looking. The less API we make public, the better otherwise, make a call. Regards changing internal usage, could do here or in a follow-on. Thanks for persisting on this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
