sunhelly commented on a change in pull request #435: HBASE-22767 System table 
RIT STUCK if their RSGroup has no highest ve…
URL: https://github.com/apache/hbase/pull/435#discussion_r324957882
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 ##########
 @@ -1923,12 +1923,23 @@ private void processAssignQueue() {
       LOG.debug("Processing assignQueue; systemServersCount=" + 
serversForSysTables.size() +
           ", allServersCount=" + servers.size());
       processAssignmentPlans(regions, null, systemHRIs,
-          serversForSysTables.isEmpty()? servers: serversForSysTables);
+          serversForSysTables.isEmpty() && !containsBogusAssignments(regions, 
systemHRIs) ?
+              servers: serversForSysTables);
     }
 
     processAssignmentPlans(regions, retainMap, userHRIs, servers);
   }
 
+  private boolean containsBogusAssignments(Map<RegionInfo, RegionStateNode> 
regions, List<RegionInfo> hirs){
+    for (RegionInfo ri : hirs) {
+      if (regions.get(ri).getRegionLocation() != null &&
+          
regions.get(ri).getRegionLocation().equals(LoadBalancer.BOGUS_SERVER_NAME)){
 
 Review comment:
   Maybe it'll be replaced by choosing a random server in DEFAULT group. There 
is something wrong when no server can be chosen for group regions in current 
codes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to