busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#issuecomment-532057453 ugh. Can't believe I didn't think of jdk requirements. Just built this on branch-1 with `-P release` so I'd have shaded artifacts to test downstream ``` [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (hadoop-profile-min-maven-min-java-banned-xerces) @ hbase-common --- [INFO] Restricted to JDK 1.7 yet org.apache.hbase.thirdparty:hbase-shaded-miscellaneous:jar:2.2.1:compile contains org/apache/hbase/thirdparty/com/google/common/annotations/Beta.class targeted to JDK 1.8 [WARNING] Rule 4: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message: HBase has unsupported dependencies. HBase requires that all dependencies be compiled with version 1.7 or earlier of the JDK to properly build from source. You appear to be using a newer dependency. You can use either "mvn -version" or "mvn enforcer:display-info" to verify what version is active. Non-release builds can temporarily build with a newer JDK version by setting the 'compileSource' property (eg. mvn -DcompileSource=1.8 clean package). Found Banned Dependency: org.apache.hbase.thirdparty:hbase-shaded-miscellaneous:jar:2.2.1 Use 'mvn dependency:tree' to locate the source of the banned dependencies. ``` Let me think about what's going to be faster here. We could exclude the stuff other than gson or we could see if updating the dependencies of hbase-thirdparty to be jdk7 compatible. I know guava still works for jdk7 if we use the "android" variant instead of "jre".
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
