langdamao commented on issue #554: HBASE-22887 Fix HFileOutputFormat2 writer roll URL: https://github.com/apache/hbase/pull/554#issuecomment-532109859 > Patch LGTM. Can we have a unit test? Thanks. Sorry for miss the last message. Yes， I think [TestHFileOutputFormat2](https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java) fits this. Is this comprehensive enought for this patch? I don't know how to make it more strong for this patch. Could you give me some suggestions, please？ Thank you so much :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
