anoopsjohn commented on a change in pull request #633: HBASE-22890 Verify the
file integrity in persistent IOEngine
URL: https://github.com/apache/hbase/pull/633#discussion_r325500197
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##########
@@ -359,24 +373,22 @@ public String getIoEngine() {
/**
* Get the IOEngine from the IO engine name
- * @param ioEngineName
- * @param capacity
* @return the IOEngine
* @throws IOException
*/
- private IOEngine getIOEngineFromName(String ioEngineName, long capacity)
+ private IOEngine getIOEngineFromName()
Review comment:
See below comment also. Actually there is no need to have any change here
now. We do not need to pass any extra args to FileIOE constructor now. No need
to even change the order of call to getIOEngineFromName() above right. Better
keep only the req change IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
