busbey commented on a change in pull request #623: HBASE-22749: Distributed MOB
compactions
URL: https://github.com/apache/hbase/pull/623#discussion_r325775568
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MobFileCleanerChore.java
##########
@@ -39,27 +39,33 @@
* mob files.
*/
@InterfaceAudience.Private
-public class ExpiredMobFileCleanerChore extends ScheduledChore {
+public class MobFileCleanerChore extends ScheduledChore {
- private static final Logger LOG =
LoggerFactory.getLogger(ExpiredMobFileCleanerChore.class);
+ private static final Logger LOG =
LoggerFactory.getLogger(MobFileCleanerChore.class);
private final HMaster master;
- private ExpiredMobFileCleaner cleaner;
+ private MobFileCleanerTool cleaner;
+ private volatile boolean running = false;
- public ExpiredMobFileCleanerChore(HMaster master) {
+ public MobFileCleanerChore(HMaster master) {
super(master.getServerName() + "-ExpiredMobFileCleanerChore", master,
master.getConfiguration()
.getInt(MobConstants.MOB_CLEANER_PERIOD,
MobConstants.DEFAULT_MOB_CLEANER_PERIOD), master
.getConfiguration().getInt(MobConstants.MOB_CLEANER_PERIOD,
MobConstants.DEFAULT_MOB_CLEANER_PERIOD), TimeUnit.SECONDS);
this.master = master;
- cleaner = new ExpiredMobFileCleaner();
+ cleaner = new MobFileCleanerTool();
cleaner.setConf(master.getConfiguration());
}
@Override
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="REC_CATCH_EXCEPTION",
justification="Intentional")
+
protected void chore() {
try {
+ if (running) {
Review comment:
not something you need to change, but I find these checks across our chores
odd. The executor of the ChoreService is supposed to guarantee that we only
have one instance of each chore running at a time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
