joshelser commented on a change in pull request #572: HBASE-22012 Space Quota:
DisableTableViolationPolicy will cause cycles of enable/disable table
URL: https://github.com/apache/hbase/pull/572#discussion_r325836869
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaBasicFunctioning.java
##########
@@ -221,4 +225,30 @@ public void testTableQuotaOverridesNamespaceQuota()
throws Exception {
Bytes.toBytes("reject"));
helper.verifyViolation(policy, tn, p);
}
+
+ @Test
+ public void testDisablePolicyQuotaAndViolate() throws Exception {
+ TableName tableName = helper.createTable();
+ helper.setQuotaLimit(tableName, SpaceViolationPolicy.DISABLE, 2L);
+ helper.writeData(tableName, SpaceQuotaHelperForTests.ONE_MEGABYTE * 3L);
+
+ HMaster master = TEST_UTIL.getMiniHBaseCluster().getMaster();
+ MasterQuotaManager quotaManager = master.getMasterQuotaManager();
+
+ // Sufficient time for all the chores to run.
+ Thread.sleep(5000);
Review comment:
What is the state you're actually expecting to happen? RegionSize reports to
be sent in?
Same issue as one of your recent PRs. Can you please convert this into an
wait+explicit check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
