[ https://issues.apache.org/jira/browse/HBASE-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247466#comment-13247466 ]
jirapos...@reviews.apache.org commented on HBASE-5717: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4640/#review6715 ----------------------------------------------------------- Ship it! The only comment I have is that there is now no test that verifies that metrics are collected when we scanned all the way to the end, but did not close the scanner. - Lars On 2012-04-05 18:15:41, Ian Varley wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4640/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-04-05 18:15:41) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. Fix for persistence of scan metrics when the scanner doesn't run to exhaustion. bq. bq. bq. This addresses bug HBASE-5717. bq. https://issues.apache.org/jira/browse/HBASE-5717 bq. bq. bq. Diffs bq. ----- bq. bq. /src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java 1309585 bq. /src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java 1309585 bq. bq. Diff: https://reviews.apache.org/r/4640/diff bq. bq. bq. Testing bq. ------- bq. bq. Altered the scan metrics unit test to show this problem (now fails without changes to ClientScanner.java). bq. bq. bq. Thanks, bq. bq. Ian bq. bq. > Scanner metrics are only reported if you get to the end of a scanner > -------------------------------------------------------------------- > > Key: HBASE-5717 > URL: https://issues.apache.org/jira/browse/HBASE-5717 > Project: HBase > Issue Type: Bug > Components: client, metrics > Reporter: Ian Varley > Priority: Minor > Attachments: ClientScanner_HBASE_5717-v2.patch, > ClientScanner_HBASE_5717.patch > > Original Estimate: 4h > Remaining Estimate: 4h > > When you turn on Scanner Metrics, the metrics are currently only made > available if you run over all records available in the scanner. If you stop > iterating before the end, the values are never flushed into the metrics > object (in the Scan attribute). > Will supply a patch with fix and test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira